Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist usage of testify/assert #206

Open
Sean-Der opened this issue Mar 23, 2024 · 2 comments
Open

Blacklist usage of testify/assert #206

Sean-Der opened this issue Mar 23, 2024 · 2 comments

Comments

@Sean-Der
Copy link
Member

What do you think of requiring require everywhere @stv0g

I am merging your change that does this in pion/ice, seems like a good idea to be consistent!

@stv0g
Copy link
Member

stv0g commented Mar 23, 2024

Hey @Sean-Der,

I am not so sure about it as its not always desired to immediatly abort a test.
Sometimes we are doing table-like tests in a single test using loops to test various combination of parameters.
If we would use require in this case, we would abort the parametrized test case on the first failing parameter combination.

@Sean-Der
Copy link
Member Author

What about allowing the lint to be disabled on a line basis?

I am taking a bunch of your ice improvement. Would love to see them propagate out across all the repos and be consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants