Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how we do temporary errors to match upstream #452

Closed
Sean-Der opened this issue Apr 25, 2022 · 2 comments
Closed

Change how we do temporary errors to match upstream #452

Sean-Der opened this issue Apr 25, 2022 · 2 comments

Comments

@Sean-Der
Copy link
Member

When upgrading the linters I found this discussion.

We should evaluate if we should change how we return temporary errors.
@at-wat
Copy link
Member

at-wat commented Apr 26, 2022

I'm not very sure what doesn't match upstream at now.
golang/go#32463 was to drop var ErrTemporary not interface { Temporary() }.
We don't have var ErrTemporary and only have implementation of interface { Temporary() } (TemporaryError struct) which matches upstream API.

@Sean-Der
Copy link
Member Author

Sounds like we do everything right, thanks for respond @at-wat! Sorry I didn't follow up sooner :(

@Sean-Der Sean-Der closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sean-Der @at-wat