Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header.SetExtension does not add an extension with id > 14 as a two-byte extension #255

Open
enobufs opened this issue Apr 1, 2024 · 1 comment
Open

Header.SetExtension does not add an extension with id > 14 as a two-byte extension #255

enobufs opened this issue Apr 1, 2024 · 1 comment
Assignees
@enobufs

Comments

@enobufs
Copy link
Member

enobufs commented Apr 1, 2024 •
edited

Your environment.

  • Version: <=v1.8.13
  • Browser: n/a

What did you do?

Add an extension with payload with size <= 16 and extension map ID > 14.

What did you expect?

Header's ExtensionProfile should be set to ExtensionProfileTwoByte.

What happened?

It is set to ExtensionProfileOneByte. Consequently, the receiver (browsers) ignores the extension because its ID is invalid.
@enobufs enobufs self-assigned this Apr 1, 2024
@enobufs
Copy link
Member Author

enobufs commented Apr 1, 2024

I will create a PR that would fix this (#255) and #249 together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enobufs enobufs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@enobufs