Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SACK chunks followed by other chunks are incorrectly handled. #204

Open
ghost opened this issue Oct 1, 2021 · 1 comment
Open

SACK chunks followed by other chunks are incorrectly handled. #204

ghost opened this issue Oct 1, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Oct 1, 2021

Hi,

This is just a curtesy bug report.

You may be aware of webrtc-rs/sctp, which is a 1:1 Rust port of pion/sctp.

Well I just submitted a fix in their codebase that I believe also affects you.

Basically, the handling of SACK chunks as it is written now incorrectly fails when two chunks are buffered inside the same packet. The fix is trivial: just changing a == to a <.
@Sean-Der
Copy link
Member

Sean-Der commented Oct 1, 2021

Thank you so much @jkauffmann-legion! Really appreciate you took the time to file over here as well :)

I will work on porting that fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sean-Der