Fix: check value length in parseTimeUnits

tanghaowillow · stv0g · commit a5096492bf13 · 2023-08-08T09:46:24.000+02:00
diff --git a/unmarshal.go b/unmarshal.go
@@ -876,6 +876,9 @@ func unmarshalMediaAttribute(l *lexer) (stateFn, error) {
 }
 
 func parseTimeUnits(value string) (num int64, err error) {
+	if len(value) == 0 {
+		return 0, fmt.Errorf("%w `%v`", errSDPInvalidValue, value)
+	}
 	k := timeShorthand(value[len(value)-1])
 	if k > 0 {
 		num, err = strconv.ParseInt(value[:len(value)-1], 10, 64)

Original file line number	Diff line number	Diff line change
`@@ -876,6 +876,9 @@ func unmarshalMediaAttribute(l *lexer) (stateFn, error) {`
`876`	`876`	`}`
`877`	`877`
`878`	`878`	`func parseTimeUnits(value string) (num int64, err error) {`
	`879`	`+ if len(value) == 0 {`
	`880`	+ return 0, fmt.Errorf("%w `%v`", errSDPInvalidValue, value)
	`881`	`+ }`
`879`	`882`	`k := timeShorthand(value[len(value)-1])`
`880`	`883`	`if k > 0 {`
`881`	`884`	`num, err = strconv.ParseInt(value[:len(value)-1], 10, 64)`