Make ProtectionProfile methods public #260
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 76.73% 76.73%
=======================================
Files 17 17
Lines 1255 1255
=======================================
Hits 963 963
Misses 200 200
Partials 92 92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
srtp_cipher.go
Outdated
| RtpAuthTagLen() (int, error) | ||
| RtcpAuthTagLen() (int, error) | ||
| // aeadAuthTagLen returns AEAD auth key length of the cipher. | ||
| // See the note below. | ||
| aeadAuthTagLen() (int, error) | ||
| AeadAuthTagLen() (int, error) |
There was a problem hiding this comment.
Acronyms are all capitals in Go's naming convention. So RTPAuth*, RTCPAuth*, AEADAuth* would be preferred
|
I have changed names as requested and added comments to make linter happy. Please take a look on test pipeline, it failed with following error: |
|
@sirzooro Great! Can you squash those commits into one. Use your description on GitHub as the commit message. I added you to the GitHub org so the tests should run (without our intervention). When it goes green we can merge :) |
sirzooro
force-pushed
the
make_protection_profile_methods_public
branch
3 times, most recently
from
aadc5e4
to
3fff0dd
Compare
|
Done :) |
This allows to get values like key length and use them with key management protocols like MIKEY, instead of creating own constants for this. Resolves pion#258
Sean-Der
force-pushed
the
make_protection_profile_methods_public
branch
from
3fff0dd
to
4ce5dff
Compare
|
Perfect! Thank you so much @sirzooro Feel free to push a tag if you need one. |
Description
Make ProtectionProfile methods public. This allows to get values like key length and use them with key management protocols like MIKEY, instead of creating own constants for this.
Reference issue
Fixes #258