Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to suggest other libraries for reading/writing media to disk #1440

Closed
lichao201626 opened this issue Sep 22, 2020 · 9 comments
Closed

Comments

@lichao201626
Copy link

lichao201626 commented Sep 22, 2020

Summary

We want h264 media support include reader and writer.

Motivation

I know there is midia support for ivf file and ogg file. But there is no support for flv file or other files. We are using the h264 video stream now and not only the vp8. We want to save file in flv format. I can only see a H264 writer, and I am curious why there is no h264 reader, or flv reader?

Describe alternatives you've considered

A clear and concise description of the alternative solutions you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@notedit
Copy link
Contributor

notedit commented Sep 22, 2020

@ldenoue
Copy link

ldenoue commented Sep 22, 2020

Is this lib using pion underneath or it depends on mediasoup?

@lichao201626
Copy link
Author

@notedit Thanks for the record example, any webrtc demo playing from flv disk file?

@lichao201626
Copy link
Author

@ldenoue Thanks for the reply, I'd like to using pion underneath, record from the camera H264 video stream and aac audio stream saving to flv files, then sharing my existed flv files support playback and etc. There are some examples saving vp8 to webm file or play from ivf disk file. As for my media format there may need some more work.

@ldenoue
Copy link

ldenoue commented Sep 22, 2020

I think that the rtp-forwarder example would let you pipe the rtp packets to ffmpeg: if you just tell ffmpeg what output format you want, it will save to the right format.

See my question and answers in this issue pion/example-webrtc-applications#62

@lichao201626
Copy link
Author

@ldenoue yeah, that's right. If I am not using third lib like ffmpeg, I am trying to read the rtp packet and codec to nalus and then write to flv tag, that is why I get the problem

@Sean-Der
Copy link
Member

Sean-Der commented Oct 4, 2020

Sorry I have been slow on this :(

@notedit your library looks fantastic! I would love to recommend it, maybe we should make a note in save-to-disk about it? I don't want to add support for more formats in-tree. The maintenance burden is pretty high, would rather see the community own little bits and pieces

@Sean-Der Sean-Der changed the title There is no media support for flv reader and flv writer or h264 reader and aac reader and aac writer Update docs to suggest other libraries for reading/writing media to disk Oct 4, 2020
@ashellunts
Copy link
Contributor

Is this issue obsolete now? Because h264 reader is added and ffmpeg example is in plan.

@Sean-Der
Copy link
Member

Sean-Der commented Nov 6, 2020

👍 I am fine with resolving!

Also with the 'features matrix' hopefully it will help people understand that pion/webrtc is solving a subset of what they are looking for.

If you need something beyond WebRTC you need to bind this with another lib.

@Sean-Der Sean-Der added this to the 3.2.0 milestone Jan 23, 2022
@Sean-Der Sean-Der removed this from the 3.2.0 milestone May 22, 2022
@Sean-Der Sean-Der closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants