pion/webrtc@v4 Release

[Sean-Der]

I merged a breaking change with 60eea43

This added support for DTLS Close Notify. This means the PeerConnection will transition to Closed directly without user interaction. Pion's documentation only suggested handling Failed and Disconnected before. Users will need to manually audit their code before upgrading.

Since we are breaking the API does anyone else things that are worth changing?

---

Changes

Complete

• DTLS Close Notify
• Fix Stats Mismatch
• Fix ICEGatheringStateChange
• Add SRTP_AEAD_AES_256_GCM
• Add all WebRTC Stats
• User Controlled SSRC (instead of Random)
• Log to stderr by default, not stdout logging#80
• SDP Marsha/Unmarshal takes ~75% less memory and is ~50% faster pion/sdp@138ce3c pion/sdp@37a57e6
• Add WHIP/WHEP Examples
• Create reusable JitterBuffer
• NewAPI creates useful MediaEngine and Interceptor by default
• Add SCTP Zero Checksum significant CPU savings for DataChannel users
• mDNS IPv6 Support
• Review/Clear Issue Backlog for dependencies
  • pion/datachannel
  • pion/sdp

TODO

• Distinct SSRC RTX Support
• Use slog (standard library logging) instead of pion/logging
• Review and add labels to all issues in pion/webrtc
• Release new major version of pion/dtls
• Review/Clear Issue Backlog for dependencies
  • pion/dtls
  • pion/example-webrtc-applications
  • pion/ice
  • pion/interceptor
  • pion/logging
  • pion/mdns
  • pion/randutil
  • pion/rtcp
  • pion/rtp
  • pion/sctp
  • pion/srtp
  • pion/stun
  • pion/transport
  • pion/turn
  • pion/webrtc

[edaniels]

Not needed but may be good to address #2292

[aalekseevx]

Maybe we can revert this revert as networkType is not "tcp4"/"tcp6"/etc according to the webrtc-stats?

[aalekseevx]

Also, I find very confusing that we have
func (pc *PeerConnection) OnICEGatheringStateChange(f func(ICEGathererState))
not
func (pc *PeerConnection) OnICEGatheringStateChange(f func(ICEGatheringState))

even though getter is more accurate:
func (pc *PeerConnection) ICEGatheringState() ICEGatheringState

I suggest it is worth making more consistent

[at-wat]

even though getter is more accurate:
func (pc *PeerConnection) ICEGatheringState() ICEGatheringState

@aalekseevx Do you mean to do polling instead of event callback?

[aalekseevx]

@at-wat, no, I think this change would be too radical :) I'm just suggesting changing the return type of OnICEGatheringStateChange from ICEGathererState to ICEGatheringState (both types already present in implementation). Mapping could be done this way

[Sean-Der]

@aalekseevx nice catch! I will make both changes

[at-wat]

Better to remove deprecated things

• SampleBuilder: Remove deprecated functions #2684

[at-wat]

Created v4 milestone to track the issues/PRs targeting v4

[Sean-Der]

@at-wat @edaniels (and anyone who is active in this thread)

What do you think of dropping pion/logging for the stdlib's slog? I don't want to put too much annoyance on users, but the less custom things we have the better!

[at-wat]

Using slog sounds good, but slog config should be configurable via webrtc.SettingEngine or something similar.
Currently, I use https://github.com/pion/zapion in my products. https://github.com/samber/slog-zap seems be usable if pion/logging is replaced by slog.

[edaniels]

I'm onboard with that. Also love using zap