Relative imports to google's type

[ffortier]

Hello. I have the following protobuf definition

~/proto/contract/contract.proto

syntax = "proto3";

import "google/protobuf/timestamp.proto";

message Metadata {
  google.protobuf.Timestamp creation_time = 1;
}

when generating the assembly script, it creates the following import

import {Timestamp} from '/some/absolute/path/where/my/code/is/google/protobuf/Timestamp.ts`

class Metadata {
  //...
}

The reason for this is this code:

as-proto/packages/as-proto-gen/src/generate/file.ts

Lines 80 to 95 in 9a242cf

	export function getOutputFilePath(
	fileDescriptor: FileDescriptorProto,
	messageOrEnumDescriptor: DescriptorProto | EnumDescriptorProto,
	parentMessageDescriptors: DescriptorProto[] = []
	) {
	const messageName = messageOrEnumDescriptor.getName();
	assert.ok(messageName !== undefined);
	const outputFileName = sanitizeFileName(`${messageName}.ts`);
	return [
	getFilePrefix(fileDescriptor),
	getNestedMessagePrefix(parentMessageDescriptors),
	outputFileName,
	].join("/");
	}

The file prefix and the nested message prefix will both be undefined because it's not a nested message and there's no package defined. Which means taht the output file path will be //Metadata.ts so when this code will be executed

as-proto/packages/as-proto-gen/src/generate/ref.ts

Lines 46 to 49 in 9a242cf

	const relativeMessageOrEnumFilePath = path.relative(
	path.dirname(fileContext.getFilePath()),
	messageOrEnumFilePath
	);

It will try to find the relative path of //Metadata.ts with google/protobuf/Timestamp.ts which will result in an absolute path containing the current working directory.

The workaround is to always set a package name to get proto/contract//Metadata.ts and this seems to work correctly.