Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support package-less protos with well known imports #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

support package-less protos with well known imports #52

wants to merge 2 commits into from

Conversation

ffortier
Copy link
Contributor

@ffortier ffortier commented Sep 7, 2023

Fixes: #51

Support package-less protos with well known imports by not joining undefined values in the output file path.

piotr-oles
piotr-oles reviewed Oct 2, 2023
View reviewed changes
Copy link
Owner

@piotr-oles piotr-oles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left one suggestion - I think this should work the same when we just filter-out undefined parts

packages/as-proto-gen/src/generate/file.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-oles piotr-oles piotr-oles left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative imports to google's type
2 participants
@ffortier @piotr-oles