Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to puppeteer 3.0.0 #79

Closed
KasparEtter opened this issue Apr 18, 2020 · 5 comments · Fixed by #81
Closed

Update to puppeteer 3.0.0 #79

KasparEtter opened this issue Apr 18, 2020 · 5 comments · Fixed by #81

Comments

@KasparEtter
Copy link
Contributor

I ran into a rendering issue: marker-mid was displayed on a a single arc in a path. I believe this bug has been captured by this issue. Chrome was rendering the SVG correctly, while ~/project/node_modules/puppeteer/.local-chromium/mac-737027/chrome-mac/Chromium.app was not. It turned out that the fix has been merged into the Chromium that ships with puppeteer 3.0.0. My current workaround is just adding "puppeteer": "^3.0.0" directly to my dependencies but naturally I would prefer an upstream fix. Thank you! 🙂

@shakiba
Copy link
Collaborator

shakiba commented Apr 29, 2020

Thanks for reporting the issue with a fix! It would be great if you make a PR.

@KasparEtter
Copy link
Contributor Author

Here you go. I haven't studied what the breaking changes in puppeteer 3.0.0 were but since it includes things like Node.js v8.x.x is no longer supported., svgexport with these updated dependencies should probably be released with a major version bump.

@KasparEtter
Copy link
Contributor Author

On a different note: I also wanted to commit the package-lock.json file (see its documentation for why) but failed to actually install puppeteer because it's currently not working with node 14. I'm too lazy to downgrade my node installation and the issue should be fixed with the 14.1.0 release.

@shakiba
Copy link
Collaborator

shakiba commented May 3, 2020

Thank, this is great! Will merge it soon, I think we can merge it as alpha version for next minor version update. Also let's cc @MichaelHeerklotz to see if he has any comment.

@KasparEtter
Copy link
Contributor Author

Since node@14.1.0 has been released in the meantime (and thus installing puppeteer works again), I added another commit to my PR in order to put package-lock.json under revision control. Otherwise, different developers can run into different issues due to differing versions of dependencies (as the dependencies are not "locked" to specific versions in the package.json file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants