New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to puppeteer 3.0.0 #79
Comments
Thanks for reporting the issue with a fix! It would be great if you make a PR. |
Here you go. I haven't studied what the breaking changes in puppeteer 3.0.0 were but since it includes things like |
On a different note: I also wanted to commit the |
Thank, this is great! Will merge it soon, I think we can merge it as alpha version for next minor version update. Also let's cc @MichaelHeerklotz to see if he has any comment. |
Since |
I ran into a rendering issue:
marker-mid
was displayed on a a single arc in a path. I believe this bug has been captured by this issue. Chrome was rendering the SVG correctly, while~/project/node_modules/puppeteer/.local-chromium/mac-737027/chrome-mac/Chromium.app
was not. It turned out that the fix has been merged into the Chromium that ships with puppeteer 3.0.0. My current workaround is just adding"puppeteer": "^3.0.0"
directly to my dependencies but naturally I would prefer an upstream fix. Thank you! 🙂The text was updated successfully, but these errors were encountered: