Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter not added in the correct location when "include" directives are involved #66

Open
DeLoWaN opened this issue Feb 5, 2020 · 1 comment

Comments

@DeLoWaN
Copy link

DeLoWaN commented Feb 5, 2020

I'm trying to manipulate php-fpm config files.

On php-fpm.conf, you have a [global] section, and at the end an include=/etc/php/7.0/fpm/pool.d/*.conf.

These additionnal config files contains others section definition.

Problem is, when you want to add a non-already-existing parameter, its get added at the end of the section, namely after the include directive. In the end, this cause the parameter to be added in another section of the config file.

I think this could be easily resolved by adding new parameters right after the the section name, what do you think ?

@pixelb
Copy link
Owner

pixelb commented Feb 6, 2020

Generally one would want to add new parameters to the end of a section.
We'd have to figure some way to make it an option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants