Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.11.0 version has a package-lock.json dependency on a github repo #151

Open
denodaeus opened this issue May 1, 2023 · 2 comments
Open

Comments

@denodaeus
Copy link

Several people (like myself) use artifactory as a proxy through to npm as our CI's don't have public internet access. This makes resolving dependencies like the below impossible.

Can you change this to pull from a real published package?

    "eslint-plugin-node-core": {
      "version": "github:iansu/eslint-plugin-node-core#fc5aa55675b696f4f51247daa705bb592b21a016",
      "from": "github:iansu/eslint-plugin-node-core",
      "dev": true,
      "requires": {
        "@babel/core": "^7.15.5",
        "@babel/eslint-parser": "^7.15.7",
        "@babel/plugin-syntax-class-properties": "^7.12.13",
        "@babel/plugin-syntax-import-assertions": "^7.14.5",
        "@babel/plugin-syntax-top-level-await": "^7.14.5",
        "eslint-plugin-markdown": "^2.2.1",
        "eslint-plugin-node-core": "^1.0.0"
      },
      "dependencies": {
        "eslint-plugin-node-core": {
          "version": "1.0.0",
          "resolved": "https://registry.npmjs.org/eslint-plugin-node-core/-/eslint-plugin-node-core-1.0.0.tgz",
          "integrity": "sha512-1i9imacKER4Noc7AkfgnPfRcirKb9GICuSmmu3q/V2VjsQA4jCYh6cExvpRsdPkX4mQh8tSpoDRrCfE7az04KA=="
        }
      }
    },
@ljharb
Copy link
Member

ljharb commented May 1, 2023

It's a dev dep, why do you need to resolve it?

@shadowspawn
Copy link
Collaborator

We didn't do more work with the linting setup. A related open issue is: #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants