Fix: Update guid filter examples for fetchItems

[glensc]

Description

Some why imdb:// or themoviedb:// regex does not filter the items, feels like pattern has "^" in it added by default.

I checked the code and it's not:

• python-plexapi/plexapi/base.py

  Lines 29 to 30 in 4780026

  	'regex': lambda v, q: re.match(q, v),
  	'iregex': lambda v, q: re.match(q, v, flags=re.IGNORECASE),

unless the re.match does it magically.
but using a complete agent name just works!

also changes iregex-> regex, the guids are always lowercase, no need for case insensitive match

additionally adds "tt12345" for legacy imdb entries

and <Guid id="xxx"> tag matching example.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the docstring for new or existing methods
• I have added tests when applicable

[glensc]

Some why imdb:// or themoviedb:// regex does not filter the items, feels like pattern has "^" in it added by default.

@JonnyWong16 can you comment why it behaves like that? i did not find code that would support that.

also thanks for the merge.

[JonnyWong16]

re.match() matches the start of a string.

https://docs.python.org/3/library/re.html#search-vs-match

[glensc]

So, using re.match rather re.search was a design error and fixing now is unwanted breaking change?

[JonnyWong16]

I don't know what the original design intent was, but it does make more sense to change it to re.search() instead. The user can specify ^ in their regex if they want to match the start of the string.

[glensc]

making the change:

• Breaking: Change regex/iregex to use re.search instead of re.match #1358

[glensc]

i'm wondering that istartswith and iendswith should also lower() the q:

    'startswith': lambda v, q: v.startswith(q),
    'istartswith': lambda v, q: v.lower().startswith(q),
    'endswith': lambda v, q: v.endswith(q),
    'iendswith': lambda v, q: v.lower().endswith(q),

if user puts uppercase search keyword the match would not be made.

in fact iexact and icontains do that for both arguments:

    'iexact': lambda v, q: v.lower() == q.lower(),
    'contains': lambda v, q: q in v,
    'icontains': lambda v, q: q.lower() in v.lower(),

[JonnyWong16]

I think doing q.lower() makes sense.

[glensc]

q.lower fix:

• Fix: Lowercase input of istartswith/iendswith #1359