Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvement for CoordinateEncoder #179

Open
OshinoMoumou opened this issue Dec 22, 2021 · 0 comments
Open

Possible improvement for CoordinateEncoder #179

OshinoMoumou opened this issue Dec 22, 2021 · 0 comments

Comments

@OshinoMoumou
Copy link

Greetings!
I noticed that in dev/utils.py, your method CoordinateEncoder referred a StackOverflow post, while a recent comment to it noted that the method works for json.dumps, json.loads and json.load, but not json.dump to file. Another comment fixed that problem.
I'm trying to learn the usefulness of such small updates on StackOverflow. Would this comment help improve your code? I understand that such improvement might not be helpful in real life situation. In that case, do you think this comment can help prevent future bugs (for example, when the code were reused somewhere else)?
I'll really appreciate it if you could kindly give me some feedback or suggestions. Thank you very much for your time.
Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant