Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering by Region and Sector should be done by WP Query #261

Open
jhung opened this issue Jul 2, 2020 · 0 comments
Open

Filtering by Region and Sector should be done by WP Query #261

jhung opened this issue Jul 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jhung
Copy link
Contributor

jhung commented Jul 2, 2020

Is your feature request related to a problem? Please describe.

Currently viewing Stories by Region and Sector is handled by displaying an index for the pcc-region and pcc-sector taxonomies. These taxonomies should be invisible to the site visitor and the view by Region / Sector should be handled by a WP query.

Describe the solution you'd like

Add Sector and Region parameters to the Organization filter, and handle the sector and region GET requests in the Page.storiesQuery() controller function.

This way, filtering content is all handled by a single form on the interface and a single WP query in the controller.

Design consideration

Adding Sector and Region options to the filters may not fit well in the current horizontal orientation. May have to consider using a filter list design (see: https://pinecone.netlify.app/components/detail/filter-list.html).

@jhung jhung added the enhancement New feature or request label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant