Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve header image layout in tablet views #56

Open
cherylhjli opened this issue Jul 5, 2019 · 0 comments
Open

Improve header image layout in tablet views #56

cherylhjli opened this issue Jul 5, 2019 · 0 comments
Assignees
@greatislander
Labels
enhancement New feature or request

Comments

@cherylhjli
Copy link

I know we didn't specifically design for tablet, so this may be out of scope and better saved for the next release. Just thought I'd flag it for now...

Screen Shot 2019-07-05 at 4 55 41 PM

I noticed that because the photo needs to stay at that fixed ratio, its not touching the off white part of the background below, the red line is just hanging out there, and in some cases (ICDE and PCC) the breadcrumbs and content run over the edges.

Screen Shot 2019-07-05 at 4 53 09 PM

Screen Shot 2019-07-05 at 4 55 50 PM

Perhaps we can touch base on this on Monday.
@greatislander greatislander added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jul 8, 2019
@greatislander greatislander modified the milestones: 2.0, 1.0 Jul 8, 2019
greatislander pushed a commit that referenced this issue Jul 11, 2019
Allow hyphens in page titles (fix #56)
f84264e
@greatislander greatislander modified the milestones: 1.0, 1.1 Jul 15, 2019
@greatislander greatislander modified the milestones: 1.1, 1.2 Jul 25, 2019
@greatislander greatislander removed this from the 1.2 milestone Sep 5, 2019
@greatislander greatislander changed the title QA-Tablet view header image Improve header image in tablet views Sep 18, 2019
@greatislander greatislander changed the title Improve header image in tablet views Improve header image layout in tablet views Sep 18, 2019
@greatislander greatislander self-assigned this Sep 18, 2019
@greatislander greatislander modified the milestones: 1.5.2, 1.5.3, 1.6.0 Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greatislander @cherylhjli