Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components which can't be used in isolation shouldn't be shown out of context #345

Open
greatislander opened this issue May 14, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@greatislander
Copy link
Collaborator

Describe the bug

As reported in #323, some components which are currently displayed in the component library don't function as expected when not in the appropriate context (the menu component needs to be within the banner and appropriately wrapped in containing elements for the mobile layout to work as expected, for example).

These components, which are not intended to be used out of context, should be hidden (their directories should be named with a _ prefix).

To Reproduce

See issues reported in #323.

Expected behavior

This component should not be shown in isolation.

Additional Context

https://fractal.build/guide/core-concepts/naming.html#ordering-and-hiding

@greatislander greatislander added the bug Something isn't working label May 14, 2020
@greatislander greatislander self-assigned this May 14, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 via automation May 14, 2020
@greatislander greatislander added this to the 1.0.0-beta.1 milestone May 14, 2020
@greatislander greatislander moved this from To do to In progress in Pinecone 1.0.0-beta.1 May 14, 2020
@greatislander greatislander moved this from In progress to To do in Pinecone 1.0.0-beta.1 May 14, 2020
@greatislander greatislander removed this from To do in Pinecone 1.0.0 May 14, 2020
@greatislander greatislander removed this from To do in Pinecone 1.0.0-beta.1 May 19, 2020
@greatislander greatislander removed this from the 1.0.0-beta.1 milestone May 19, 2020
@greatislander greatislander added this to the 1.0.0 milestone Aug 5, 2020
@greatislander greatislander added enhancement New feature or request and removed bug Something isn't working labels Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant