Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Add footer to info reference asset #161

Open
hborawski opened this issue Sep 29, 2023 · 3 comments · May be fixed by #175
Open

React: Add footer to info reference asset #161

hborawski opened this issue Sep 29, 2023 · 3 comments · May be fixed by #175
Assignees
@vg300
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@hborawski
Copy link
Contributor

To better model some real world scenarios, the info asset should be able to render content below the actions.

Add a footer to the info asset and render it in the react reference asset
@hborawski hborawski added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Sep 29, 2023
This was referenced Sep 29, 2023
Closed
Open
@GOYALAYUSH782
Copy link

@hborawski I did not understand the requirement? Can u explain by visuals maybe? I can enhance for react.

@hborawski
Copy link
Contributor Author

The info asset is used to represent a whole page, many applications render footer content consistently across screens for common links, like contact information.

This page itself is an example of that:

Screenshot 2023-10-06 at 8 42 03 AM

So the ask with this enhancement is to enable the info asset to render content below the actions, you can view the current info asset here: https://player-ui.github.io/latest/storybook-demo/?path=/story/reference-assets-info--info

@vg300
Copy link

vg300 commented Oct 8, 2023

Hi @hborawski, is this issue still open? I would like to take it up.

@vg300 vg300 linked a pull request Oct 8, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vg300 vg300

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add footer in info component vg300/player
3 participants
@hborawski @GOYALAYUSH782 @vg300