Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: AssetTestHelper getAsset can't register assets through plugins arg #325

Open
hborawski opened this issue Mar 23, 2024 · 0 comments · May be fixed by #372
Open

iOS: AssetTestHelper getAsset can't register assets through plugins arg #325

hborawski opened this issue Mar 23, 2024 · 0 comments · May be fixed by #372
Labels
bug Something isn't working

Comments

@hborawski
Copy link
Contributor

Describe the bug

Plugins that guard on the type of player being applied to, just like the ReferenceAssetsPlugin, don't work with getAsset in AssetTestHelper because it always uses TestPlayer.

To Reproduce

Remove https://github.com/player-ui/player/blob/main/ios/packages/reference-assets/ViewInspector/SwiftUI/ActionAssetTests.swift#L19-L22 and pass the ReferenceAssetsPlugin to https://github.com/player-ui/player/blob/main/ios/packages/reference-assets/ViewInspector/SwiftUI/ActionAssetTests.swift#L43

Expected behavior

Test passes

Screenshots

Environment:

  • OS: iOS
  • Version: Any

Additional context
@hborawski hborawski added the bug Something isn't working label Mar 23, 2024
@hborawski hborawski linked a pull request May 31, 2024 that will close this issue
Open
6 tasks
@hborawski hborawski linked a pull request May 31, 2024 that will close this issue
iOS ReferenceAssetsPlugin: check registry type instead of player type #372
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iOS ReferenceAssetsPlugin: check registry type instead of player type player-ui/player
1 participant
@hborawski