Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel-6] Convert docs build to basic webpack #327

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

adierkens
Copy link
Member

Far from perfect & optimized (we should still try to leverage nextjs/remix if possible, and generate a proper static site).
This gets us a working docs site using bazel-6/rules_js & react@18.

chakra-ui wasn't playing nicely with nextjs + react@18, and the options were to either replace nextjs or chakra -- and the path of least resistance was to swap out nextjs temporarily. The docs site should look and behave the same as it did prior, just with less optimizations.

@adierkens adierkens added documentation Changes only affect the documentation Bazel 6 Anything related to the migration to bazel 6 labels Apr 1, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (98a8d91) to head (ad4a93a).
Report is 4 commits behind head on bazel-6.

Additional details and impacted files
@@           Coverage Diff            @@
##           bazel-6     #327   +/-   ##
========================================
  Coverage    91.70%   91.71%           
========================================
  Files          332      332           
  Lines        26731    26729    -2     
  Branches      1935     1935           
========================================
  Hits         24514    24514           
+ Misses        2203     2202    -1     
+ Partials        14       13    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hborawski hborawski merged commit c7943b1 into bazel-6 May 17, 2024
8 of 10 checks passed
@hborawski hborawski deleted the bazel-6-docs branch May 17, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bazel 6 Anything related to the migration to bazel 6 documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants