Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multi node switch fixv1 #347

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

mercillo
Copy link
Contributor

@mercillo mercillo commented Apr 24, 2024

When multinodes contained switches; the switch would not evaluate correctly.

          id: 'foo',
          fields: [
            staticSwitch: [
              {
                case: '{{foo.baz}}',
                asset: {
                  id: 'input-1',
                  type: 'input',
                },
              },
              {
                case: '{{foo.bar}}',
                asset: {
                  id: 'input-2',
                  type: 'input',
                },
              },
            ],
          ],

when staticSwitches get evaluated to false; the asset should not live in the AST, however there was a bug that caused staticSwitches not to get read as a switch when they were inside of multinodes.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Version

Published prerelease version: 0.7.3-next.2

Changelog

🐛 Bug Fix

📝 Documentation

Authors: 8

@mercillo mercillo added the patch Increment the patch version when merged label Apr 24, 2024
.npmrc Show resolved Hide resolved
@mercillo mercillo marked this pull request as ready for review April 24, 2024 22:45
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.93%. Comparing base (e3d95ae) to head (8a0d69f).
Report is 5 commits behind head on main.

Files Patch % Lines
core/player/src/view/parser/index.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   81.90%   81.93%   +0.02%     
==========================================
  Files         133      133              
  Lines        4619     4621       +2     
  Branches     1142     1144       +2     
==========================================
+ Hits         3783     3786       +3     
  Misses        555      555              
+ Partials      281      280       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy KetanReddy merged commit f087f75 into player-ui:main Apr 25, 2024
8 of 9 checks passed
@intuit-svc intuit-svc mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants