Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Returning Effective Type from the SDK Fill in Generics and Compute Effective Objects #27

Open
KetanReddy opened this issue Jan 18, 2023 · 0 comments
Labels
enhancement New feature or request hacktoberfest minor Increment the minor version when merged XLR Related to XLR Functionality

Comments

@KetanReddy
Copy link
Member

KetanReddy commented Jan 18, 2023

All of the logic that we do in validation to fill in generics, compute the effective object results from intersections/unions and solve the extends notation for ObjectType nodes we should all compute when we return an object from the SDK. Currently we only expand the extends notation but by doing all the other operations we can return a more useful type for some operations (like generating JSON that fills in some of those objects in drag and drop). If we compute these objects when retrieving them from the SDK, they should also be added to the cache used for validation in #24.

@KetanReddy KetanReddy added enhancement New feature or request minor Increment the minor version when merged XLR Related to XLR Functionality labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest minor Increment the minor version when merged XLR Related to XLR Functionality
Projects
None yet
Development

No branches or pull requests

1 participant