Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@player-tools/json-language-service] DuplicateIdPlugin: Template Support #91

Open
hborawski opened this issue Apr 8, 2024 · 0 comments
Open

[@player-tools/json-language-service] DuplicateIdPlugin: Template Support #91

hborawski opened this issue Apr 8, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed patch Increment the patch version when merged

Comments

@hborawski
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The existing DuplicateIdPlugin only errors for IDs that are hardcoded the same, content templates, or nested templates, may produce duplicate IDs in assets if the _indexN_ replacement is not used in the identifier.

Describe the solution you'd like

The DuplicateIdPlugin should throw errors if an ID in a template does not use the _indexN_ replacement in identifiers for template content.

Additional context

For nested templates, may need to ensure the ID contains the _indexN_ replacement for all the template levels above it
@hborawski hborawski added the enhancement New feature or request label Apr 8, 2024
@KetanReddy KetanReddy added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed patch Increment the patch version when merged labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hborawski @KetanReddy