Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple test failures using AdoptOpenJDK 8u252 #253

Closed
ignasi35 opened this issue May 11, 2020 · 4 comments
Closed

Multiple test failures using AdoptOpenJDK 8u252 #253

ignasi35 opened this issue May 11, 2020 · 4 comments
Labels
topic:documentation type:defect

Comments

@ignasi35
Copy link
Member

See akka/akka-grpc#946

TL,DR; supporting ALPN in the JDK directly (added in 8u252) requires upstream libraries to adapt how ALPN is used.
@raboof
Copy link
Member

raboof commented May 29, 2020

What is the way forward here? I see a couple of options:

  • Support JDK11 and JDK8, but JDK8 only before 8u252 (until Support ALPN in latest JDK 8 builds grpc/grpc-java#7060 makes it)
  • Support JDK11, drop support for JDK8
  • Support JDK11, JDK8 < 8u252 and JDK8u252-with-native-openssl (which means refactoring things so we can provide TrustManager implementations rather than an SSLContext).

I'm leaning towards '2' or '1'.

raboof added a commit to raboof/lagom-samples that referenced this issue May 29, 2020
@raboof
Disable lagom-grpc on jdk8 for now
dd02bce 
Until playframework/play-grpc#253 is
resolved
This was referenced May 29, 2020
Closed
Closed
@ignasi35
Copy link
Member Author

ignasi35 commented Jun 2, 2020 •
edited

I'm leaning towards '2' or '1'.

I agree.

@ignasi35 ignasi35 mentioned this issue Jun 2, 2020
Merged
@raboof
Copy link
Member

raboof commented Sep 30, 2020

grpc/grpc-java#7060 has since made it into 1.32.1 and akka-grpc 1.0.2 has updated to that version

This was referenced Sep 30, 2020
Merged
Merged
@raboof
Copy link
Member

raboof commented Sep 30, 2020

(Not tested in depth but trusting CI here 🤞 )

@raboof raboof closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic:documentation type:defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raboof @ignasi35