You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The delete action menu item in the Plone toolbar uses pat-modal, with an actionOptions data object to provide configuration for the pattern. This is the rendered HTML:
Both disableAjaxFormSubmit and redirectOnResponse are set to true. However, looking at the pattern source, it appears that the place where redirectOnResponse is checked would never be reached if disableAjaxFormSubmit === true:
fulv
changed the title
Toolbar delete action - ignored actionOption redirectOnResponse for modal pattern
Toolbar delete action - actionOption redirectOnResponse for modal pattern is ignored
Oct 13, 2020
The delete action menu item in the Plone toolbar uses pat-modal, with an
actionOptions
data object to provide configuration for the pattern. This is the rendered HTML:Both
disableAjaxFormSubmit
andredirectOnResponse
are set totrue
. However, looking at the pattern source, it appears that the place whereredirectOnResponse
is checked would never be reached ifdisableAjaxFormSubmit === true
:https://github.com/plone/mockup/blob/master/mockup/patterns/modal/pattern.js#L383
Therefore, I would say that setting
redirectOnResponse
is superfluous.The action menu comes from here:
https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/profiles/default/actions.xml#L192
The text was updated successfully, but these errors were encountered: