Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable overriding favicon from Helmet component #6013

Open
giuliaghisini opened this issue May 13, 2024 · 2 comments
Open

enable overriding favicon from Helmet component #6013

giuliaghisini opened this issue May 13, 2024 · 2 comments
Assignees

Comments

@giuliaghisini
Copy link
Contributor

if i want to load favicon differently than loading it from /public folder, i have to override the /helpers/Html.js component because favicon is statically linked here and i'm not able to override it by Helmet component.

@stevepiercy
Copy link
Collaborator

@giuliaghisini
Copy link
Contributor Author

giuliaghisini commented May 14, 2024

Is this a duplicate of either?

no.. here we need to set favicon from an api response, not from a static folder. Otherwise, i thin for all this 3 issues the solution is the same.. maybe the solutions are two:

  1. move the markup of favicon inside a specific component that will be overridable
  2. make Helmet component able to set/render the favicon markup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants