Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors when building projects with multiple requirements #112

Open
edublancas opened this issue Aug 28, 2022 · 1 comment
Open

errors when building projects with multiple requirements #112

edublancas opened this issue Aug 28, 2022 · 1 comment

Comments

@edublancas
Copy link
Contributor

edublancas commented Aug 28, 2022

adding the suffix in the wrong place

the feature that allows a single project to have multiple docker images is adding the suffix to the tag, instead of the name. Furthermore, it's adding default to the default tag, but this should not happen. For example, it'll generate:

project-name:latest-default
project-name:latest-another

but it should be:

project-name:latest
project-name-another:latest

argo spec does not take multiple docker images into account

when exporting to argo, all the tasks use the same docker image, I haven't tested with AWS Batch or Airflow, but I suspect the same.

correct image building

Also, I'm unsure if the logic to build the docker images is correctly implemented. I tried running the example and then checked the "plot" image:

docker run multiple_requirements_project:latest-plot-ploomber pip freeze | grep seaborn

and seaborn isn't there

@edublancas edublancas changed the title adding the suffix in the wrong place errors when building projects with multiple requirements Aug 28, 2022
@edublancas
Copy link
Contributor Author

Note: "adding the suffix in the wrong place" has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant