From 2df24bd1f137a02794ae2c89f8c07a2eeabd68c1 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Fri, 11 Nov 2022 18:49:14 -0500 Subject: [PATCH 1/2] fix mapbox clearOutline calls --- src/plots/mapbox/mapbox.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plots/mapbox/mapbox.js b/src/plots/mapbox/mapbox.js index 7e737ed0e8..061495d070 100644 --- a/src/plots/mapbox/mapbox.js +++ b/src/plots/mapbox/mapbox.js @@ -593,7 +593,7 @@ proto.updateFx = function(fullLayout) { map.off('click', self.onClickInPanHandler); if(selectMode(dragMode) || drawMode(dragMode)) { map.dragPan.disable(); - map.on('zoomstart', self.clearSelect); + map.on('zoomstart', self.clearOutline); self.dragOptions.prepFn = function(e, startX, startY) { prepSelect(e, startX, startY, self.dragOptions, dragMode); @@ -602,7 +602,7 @@ proto.updateFx = function(fullLayout) { dragElement.init(self.dragOptions); } else { map.dragPan.enable(); - map.off('zoomstart', self.clearSelect); + map.off('zoomstart', self.clearOutline); self.div.onmousedown = null; self.div.ontouchstart = null; self.div.removeEventListener('touchstart', self.div._ontouchstart); From 895ace53e1a673f1aeba1d50e998e1c7249dff3f Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Fri, 11 Nov 2022 18:59:59 -0500 Subject: [PATCH 2/2] draft log for PR 6367 --- draftlogs/6367_fix.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/6367_fix.md diff --git a/draftlogs/6367_fix.md b/draftlogs/6367_fix.md new file mode 100644 index 0000000000..910b6c0a25 --- /dev/null +++ b/draftlogs/6367_fix.md @@ -0,0 +1 @@ + - Fix mapbox clearOutline calls (regression introduced in 2.13.0) [[#6367](https://github.com/plotly/plotly.js/pull/6367)]