From 68375a1bfcf42fba38b10b454a499223103702e1 Mon Sep 17 00:00:00 2001 From: "Marvin A. Ruder" Date: Thu, 7 Mar 2024 00:59:55 +0100 Subject: [PATCH] fix(dependencies): fix peer dependencies (#2528) * Fix (peer) dependencies * Declare `prop-types` as a dependency of `@nivo/core` (as recommended in their README) * Declare `react` as a peer dependency of `@nivo/tooltip` * Update lockfile Fixes #2401 Signed-off-by: Marvin A. Ruder * Use and declare the same `pnpm` version as `ci/codesandbox` uses Signed-off-by: Marvin A. Ruder --------- Signed-off-by: Marvin A. Ruder --- package.json | 2 +- packages/core/package.json | 4 ++-- packages/tooltip/package.json | 3 +++ pnpm-lock.yaml | 23 +++++++++++++---------- 4 files changed, 19 insertions(+), 13 deletions(-) diff --git a/package.json b/package.json index 534f63ea55..6565999801 100644 --- a/package.json +++ b/package.json @@ -90,5 +90,5 @@ "type": "opencollective", "url": "https://opencollective.com/nivo" }, - "packageManager": "pnpm@8.3.1" + "packageManager": "pnpm@8.10.2" } diff --git a/packages/core/package.json b/packages/core/package.json index 8bf621e753..d680d126dd 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -32,10 +32,10 @@ "d3-scale-chromatic": "^3.0.0", "d3-shape": "^1.3.5", "d3-time-format": "^3.0.0", - "lodash": "^4.17.21" + "lodash": "^4.17.21", + "prop-types": "^15.7.2" }, "peerDependencies": { - "prop-types": ">= 15.5.10 < 16.0.0", "react": ">= 16.14.0 < 19.0.0" }, "publishConfig": { diff --git a/packages/tooltip/package.json b/packages/tooltip/package.json index 0f2ab4cd1b..dccdd87cc8 100644 --- a/packages/tooltip/package.json +++ b/packages/tooltip/package.json @@ -24,6 +24,9 @@ "@nivo/core": "workspace:*", "@react-spring/web": "9.4.5 || ^9.7.2" }, + "peerDependencies": { + "react": ">= 16.14.0 < 19.0.0" + }, "publishConfig": { "access": "public" } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 62c70b610b..b34eb2df75 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -752,7 +752,7 @@ importers: specifier: ^4.17.21 version: 4.17.21 prop-types: - specifier: '>= 15.5.10 < 16.0.0' + specifier: ^15.7.2 version: 15.8.1 react: specifier: 18.2.0 @@ -1503,6 +1503,9 @@ importers: '@react-spring/web': specifier: 9.4.5 || ^9.7.2 version: 9.7.2(react-dom@18.2.0)(react@18.2.0) + react: + specifier: 18.2.0 + version: 18.2.0 packages/treemap: dependencies: @@ -11443,6 +11446,7 @@ packages: dependencies: ms: 2.1.3 supports-color: 5.5.0 + dev: true /debug@3.2.7(supports-color@8.1.1): resolution: {integrity: sha512-CFjzYYAi4ThfiQvizrFQevTTXHtnCqWfe7x1AhgEscTz6ZbLbfoLRLPugTQyBth6f8ZERVUSyWHFD/7Wu4t1XQ==} @@ -11454,7 +11458,6 @@ packages: dependencies: ms: 2.1.3 supports-color: 8.1.1 - dev: true /debug@4.3.4(supports-color@5.5.0): resolution: {integrity: sha512-PRWFHuSU3eDtQJPvnNY7Jcket1j0t5OuOsFzPPzsekD52Zl8qUfFIPEiswXqIvHWGVHOgX+7G/vCNNhehwxfkQ==} @@ -11734,7 +11737,7 @@ packages: '@types/tmp': 0.0.33 application-config-path: 0.1.0 command-exists: 1.2.9 - debug: 3.2.7(supports-color@5.5.0) + debug: 3.2.7(supports-color@8.1.1) eol: 0.9.1 get-port: 3.2.0 glob: 7.2.3 @@ -12493,7 +12496,7 @@ packages: /eslint-import-resolver-node@0.3.6: resolution: {integrity: sha512-0En0w03NRVMn9Uiyn8YRPDKvWjxCWkslUEhGNTdGx15RvPJYQ+lbOlqrlNI2vEAs4pDYK4f/HN2TbDmk5TP0iw==} dependencies: - debug: 3.2.7(supports-color@5.5.0) + debug: 3.2.7(supports-color@8.1.1) resolve: 1.22.2 transitivePeerDependencies: - supports-color @@ -12502,7 +12505,7 @@ packages: /eslint-import-resolver-node@0.3.7: resolution: {integrity: sha512-gozW2blMLJCeFpBwugLTGyvVjNoeo1knonXAcatC6bjPBZitotxdWf7Gimr25N4c0AAOo4eOUfaG82IJPDpqCA==} dependencies: - debug: 3.2.7(supports-color@5.5.0) + debug: 3.2.7(supports-color@8.1.1) is-core-module: 2.12.0 resolve: 1.22.2 transitivePeerDependencies: @@ -12528,7 +12531,7 @@ packages: optional: true dependencies: '@typescript-eslint/parser': 5.59.1(eslint@8.39.0)(typescript@4.9.5) - debug: 3.2.7(supports-color@5.5.0) + debug: 3.2.7(supports-color@8.1.1) eslint-import-resolver-node: 0.3.6 find-up: 2.1.0 pkg-dir: 2.0.0 @@ -12558,7 +12561,7 @@ packages: optional: true dependencies: '@typescript-eslint/parser': 5.59.1(eslint@7.32.0)(typescript@4.9.5) - debug: 3.2.7(supports-color@5.5.0) + debug: 3.2.7(supports-color@8.1.1) eslint: 7.32.0 eslint-import-resolver-node: 0.3.7 transitivePeerDependencies: @@ -12636,7 +12639,7 @@ packages: array-includes: 3.1.6 array.prototype.flat: 1.3.1 array.prototype.flatmap: 1.3.1 - debug: 3.2.7(supports-color@5.5.0) + debug: 3.2.7(supports-color@8.1.1) doctrine: 2.1.0 eslint: 7.32.0 eslint-import-resolver-node: 0.3.7 @@ -13219,7 +13222,7 @@ packages: resolution: {integrity: sha512-/l77JHcOUrDUX8V67E287VEUQT0lbm71gdGVoodnlWBziarYKgMcpqT7xvh/HM8Jv52phw8Bd8tY+a7QjOr7Yg==} engines: {node: '>=6.0.0'} dependencies: - debug: 3.2.7(supports-color@5.5.0) + debug: 3.2.7(supports-color@8.1.1) es6-promise: 4.2.8 raw-body: 2.4.3 transitivePeerDependencies: @@ -18875,7 +18878,7 @@ packages: engines: {node: '>= 4.4.x'} hasBin: true dependencies: - debug: 3.2.7(supports-color@5.5.0) + debug: 3.2.7(supports-color@8.1.1) iconv-lite: 0.4.24 sax: 1.2.4 transitivePeerDependencies: