feat(heatmap): fix missing hooks deps

plouc · Jan 12, 2022 · 7025bb9 · 7025bb9
1 parent 37136c9
commit 7025bb9
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/packages/heatmap/src/HeatMapCanvas.tsx b/packages/heatmap/src/HeatMapCanvas.tsx
@@ -164,6 +164,7 @@ const InnerHeatMapCanvas = <Datum extends HeatMapDatum, ExtraProps extends objec
         })
     }, [
         canvasEl,
+        layers,
         cells,
         outerWidth,
         outerHeight,
@@ -234,7 +235,7 @@ const InnerHeatMapCanvas = <Datum extends HeatMapDatum, ExtraProps extends objec
 
             onClick?.(activeCell, event)
         },
-        [cells, activeCell, onClick]
+        [activeCell, onClick]
     )
 
     return (

diff --git a/packages/heatmap/src/HeatMapCellCircle.tsx b/packages/heatmap/src/HeatMapCellCircle.tsx
@@ -22,7 +22,7 @@ const NonMemoizedHeatMapCellCircle = <Datum extends HeatMapDatum>({
             onMouseLeave: onMouseLeave ? onMouseLeave(cell) : undefined,
             onClick: onClick ? onClick(cell) : undefined,
         }),
-        [cell, onMouseEnter, onMouseMove, onMouseLeave]
+        [cell, onMouseEnter, onMouseMove, onMouseLeave, onClick]
     )
 
     return (

diff --git a/packages/heatmap/src/HeatMapCellRect.tsx b/packages/heatmap/src/HeatMapCellRect.tsx
@@ -23,7 +23,7 @@ const NonMemoizedHeatMapCellRect = <Datum extends HeatMapDatum>({
             onMouseLeave: onMouseLeave ? onMouseLeave(cell) : undefined,
             onClick: onClick ? onClick(cell) : undefined,
         }),
-        [cell, onMouseEnter, onMouseMove, onMouseLeave]
+        [cell, onMouseEnter, onMouseMove, onMouseLeave, onClick]
     )
 
     return (

diff --git a/packages/heatmap/src/hooks.ts b/packages/heatmap/src/hooks.ts
@@ -251,7 +251,18 @@ export const useHeatMap = <
 
                 return computedCell
             }),
-        [cells, getColor, getBorderColor, getLabelTextColor, formatValue, getLabel, activeIds]
+        [
+            cells,
+            getColor,
+            getBorderColor,
+            getLabelTextColor,
+            formatValue,
+            getLabel,
+            activeIds,
+            opacity,
+            activeOpacity,
+            inactiveOpacity,
+        ]
     )
 
     return {