From 7025bb9db384dcf162713b57fab5c1c84819731e Mon Sep 17 00:00:00 2001 From: plouc Date: Sun, 9 Jan 2022 08:56:08 +0900 Subject: [PATCH] feat(heatmap): fix missing hooks deps --- packages/heatmap/src/HeatMapCanvas.tsx | 3 ++- packages/heatmap/src/HeatMapCellCircle.tsx | 2 +- packages/heatmap/src/HeatMapCellRect.tsx | 2 +- packages/heatmap/src/hooks.ts | 13 ++++++++++++- 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/packages/heatmap/src/HeatMapCanvas.tsx b/packages/heatmap/src/HeatMapCanvas.tsx index 9264015a99..aefd92a6b9 100644 --- a/packages/heatmap/src/HeatMapCanvas.tsx +++ b/packages/heatmap/src/HeatMapCanvas.tsx @@ -164,6 +164,7 @@ const InnerHeatMapCanvas = ({ onMouseLeave: onMouseLeave ? onMouseLeave(cell) : undefined, onClick: onClick ? onClick(cell) : undefined, }), - [cell, onMouseEnter, onMouseMove, onMouseLeave] + [cell, onMouseEnter, onMouseMove, onMouseLeave, onClick] ) return ( diff --git a/packages/heatmap/src/HeatMapCellRect.tsx b/packages/heatmap/src/HeatMapCellRect.tsx index 501f061475..9b9599770c 100644 --- a/packages/heatmap/src/HeatMapCellRect.tsx +++ b/packages/heatmap/src/HeatMapCellRect.tsx @@ -23,7 +23,7 @@ const NonMemoizedHeatMapCellRect = ({ onMouseLeave: onMouseLeave ? onMouseLeave(cell) : undefined, onClick: onClick ? onClick(cell) : undefined, }), - [cell, onMouseEnter, onMouseMove, onMouseLeave] + [cell, onMouseEnter, onMouseMove, onMouseLeave, onClick] ) return ( diff --git a/packages/heatmap/src/hooks.ts b/packages/heatmap/src/hooks.ts index bb4dc84608..5cd0a76045 100644 --- a/packages/heatmap/src/hooks.ts +++ b/packages/heatmap/src/hooks.ts @@ -251,7 +251,18 @@ export const useHeatMap = < return computedCell }), - [cells, getColor, getBorderColor, getLabelTextColor, formatValue, getLabel, activeIds] + [ + cells, + getColor, + getBorderColor, + getLabelTextColor, + formatValue, + getLabel, + activeIds, + opacity, + activeOpacity, + inactiveOpacity, + ] ) return {