Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar): add support for patterns and gradients #1807

Merged
merged 10 commits into from Nov 7, 2021

Conversation

adamberro
Copy link
Contributor

Hi, we currently use this chart but need to support patterns with it.
This PR adds defs and fill props to radar chart to support patterns and gradients.

Screen Shot 2021-10-18 at 2 53 18 PM

Copy link
Owner

@plouc plouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a little comment on the story name.

packages/radar/stories/radar.stories.tsx Outdated Show resolved Hide resolved
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 18, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 399b889:

Sandbox Source
nivo Configuration

@plouc plouc added the radar @nivo/radar package label Nov 7, 2021
@plouc plouc merged commit 0b3bdb0 into plouc:master Nov 7, 2021
@plouc
Copy link
Owner

plouc commented Nov 7, 2021

Thank you for your contribution @adamberro! It will be included in the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
radar @nivo/radar package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants