You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suspect this has to do with the use of d3-force which needs to know about the width of the elements.
EDIT: the d3-force positions take the borderWidth into account, so passing down the prop seems to suffice to display the borders. The canvas rendering do not use the borderWidth property, however.
I'll try to submit a PR soon to propose a solution.
The text was updated successfully, but these errors were encountered:
The border width property of a swarm plot is not being used in the component.
To Reproduce
Go to https://nivo.rocks/swarmplot/ and move the
borderWidth
input. Nothing happens on the graph.Expected behavior
The border width of the circles is affected by the
borderWidth
setting.Screenshots
Cause
The width is hardcoded to 0 here:
nivo/packages/swarmplot/src/SwarmPlot.tsx
Line 144 in 399215b
I suspect this has to do with the use ofd3-force
which needs to know about the width of the elements.EDIT: the d3-force positions take the borderWidth into account, so passing down the prop seems to suffice to display the borders. The canvas rendering do not use the
borderWidth
property, however.I'll try to submit a PR soon to propose a solution.
The text was updated successfully, but these errors were encountered: