Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borderWidth is not being used in swarm plot #1813

Closed
benjamintd opened this issue Oct 27, 2021 · 0 comments · Fixed by #1814
Closed

borderWidth is not being used in swarm plot #1813

benjamintd opened this issue Oct 27, 2021 · 0 comments · Fixed by #1814

Comments

@benjamintd
Copy link
Contributor

benjamintd commented Oct 27, 2021

The border width property of a swarm plot is not being used in the component.

To Reproduce
Go to https://nivo.rocks/swarmplot/ and move the borderWidth input. Nothing happens on the graph.

Expected behavior
The border width of the circles is affected by the borderWidth setting.

Screenshots
image

Cause

The width is hardcoded to 0 here:

I suspect this has to do with the use of d3-force which needs to know about the width of the elements.
EDIT: the d3-force positions take the borderWidth into account, so passing down the prop seems to suffice to display the borders. The canvas rendering do not use the borderWidth property, however.

I'll try to submit a PR soon to propose a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant