Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeRange omits last data value #2333

Open
naughton opened this issue May 9, 2023 · 0 comments · May be fixed by #2457
Open

TimeRange omits last data value #2333

naughton opened this issue May 9, 2023 · 0 comments · May be fixed by #2457
Labels
bug 📆 calendar @nivo/calendar package pinned

Comments

@naughton
Copy link

naughton commented May 9, 2023

When no explicit to prop is passed in, TimeRange uses the last data element's day field to determine the time range.

However, it does not compute this correctly and leaves off the last data entry.

To Reproduce

https://codesandbox.io/s/nivo-calendar-timerange-off-by-one-bug-kpjbgc

Steps to reproduce the behavior:

  1. Go to 'codesandbox'
  2. Look at 3 dates in data.
  3. See that third date does not appear.

Expected behavior
All Three Days would appear.

Screenshots

image

Desktop (please complete the following information):

  • OS: windows 11
  • Browser: chrome
  • Version: 112
@plouc plouc added 📆 calendar @nivo/calendar package bug pinned labels May 9, 2023
@philstainer philstainer linked a pull request Oct 31, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 📆 calendar @nivo/calendar package pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(calendar): compute cell positions missing end date philstainer/nivo
2 participants
@naughton @plouc