Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript, Sankey: Missing attributes in SankeyNodeDatum / SankeyLinkDatum Type #2501

Open
philemonSchulz opened this issue Jan 26, 2024 · 1 comment

Comments

@philemonSchulz
Copy link

When using the Sankey Component with TypeScript, the onClick Method returns either a "SankyNodeDatum" or "SankeyLinkDatum" object.
When logging, a lot of attributes like "id", "sourceLinks" or "targetLinks" are displayed. However, the defined types only allow for "color", "formattedValue", "index" and "value".

It would be great if the other attributes are represented in the type as well.

@wastedev
Copy link

Also it have some types inconsistencies on layers prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants