Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotsItemSymbolProps lacks datum #2515

Open
jamesarosen opened this issue Feb 14, 2024 · 0 comments
Open

DotsItemSymbolProps lacks datum #2515

jamesarosen opened this issue Feb 14, 2024 · 0 comments

Comments

@jamesarosen
Copy link

@nivo/core's DotsItemSymbolProps is defined as

export interface DotsItemSymbolProps {
    size: number
    color: string
    borderWidth: number
    borderColor: string
}

Conversely, @nivo/line's PointSymbolProps is defined as

export interface PointSymbolProps {
    borderColor: string
    borderWidth: number
    color: string
    datum: Datum
    size: number
}

@nivo/line's <Points> passes pointSymbol in to DotsItem as symbol. That works because <DotsItem> actually passes datum even though it's not declared.

This makes it hard to implement a custom <Points> layer since -- according to the types -- those two are incompatible.

That's incompatible with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant