Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support excluding sites by condition #133

Open
JWandscheer opened this issue Jul 14, 2023 · 2 comments
Open

Support excluding sites by condition #133

JWandscheer opened this issue Jul 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@JWandscheer
Copy link

Feature request

Summary

It would be nice to support excluding Pages from the sitemap by model-attributes.

Why is it needed?

For example: We have a model "TeamMember" which has a boolean attribute hasProfilePage. The frontend can only show the profile page of this person, if this value is true. The sitemap unfortunately contains all members with their slugs, which leads to 404 errors if hasProfilePage is false

Suggested solution(s)

In the Sitemap url bundles popup, add an area for building conditions for in- or excluding pages based on model attributes.

Related issue(s)/PR(s)

I think this would be solved by #109

@boazpoolman boazpoolman added the enhancement New feature or request label Jul 15, 2023
@laszlo-san
Copy link

If I might add another enhancement what is related to this one and also the PR that is mentioned in it:

The current implementation does not allow to have multiple instances of content types ( * language) in the URL bundles. If you have a bundle with a content type, you can not create a new one for that type, only edit the old one. But it would be great to be able to not just filter entries on the content type, but map those filtersets to different URL bundles.

Why is it needed?

Take a model of Project that has states: planning, doing, done.
The URL for each state can be different in the frontend like: /coming-soon/[id] , /what-we-do/[id], and /what-is-done/[id] with the respective states as filters.

Suggested solution

The url bundles can be grouped/unique by type, langcode AND pattern (and/or filter?)

@boazpoolman
Copy link
Member

That seems like an excellent addition to this feature request.
Thanks @laszlo-san

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants