Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URL translation sets for custom URLs #135

Open
innopbo opened this issue Aug 21, 2023 · 2 comments
Open

Allow URL translation sets for custom URLs #135

innopbo opened this issue Aug 21, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@innopbo
Copy link

innopbo commented Aug 21, 2023

Feature request

Summary

Adding a URL bundle for a single type with no dynamic field in the Pattern.

Why is it needed?

Currently adding a URL bundle requires there to be a field in the Pattern. For single types this isn't really necessary because there is no dynamic part to the path. The suggested way of adding non-dynamic urls is via the Custom URLs tab. However, because custom urls have no language setting they don't generate a Translation Set in the sitemap xml.
I'd like to be able to generate sitemap entries with translation sets for urls related to Single types.

Suggested solution(s)

I see a couple of options:

  • Allow adding a URL bundle which doesn't have a dynamic pattern (probably limited to Single Types)
  • Make the language option available for Custom URLs

My workaround for now is adding a slug field to the single type and using this in the URL bundle, but this adds the overhead of another place where the slug needs to be kept in sync with the front-end.

Related issue(s)/PR(s)

#98 (I believe the reporter of this issue was looking for the same functionality)

p.s. Thanks for your great work on this handy plugin!

@boazpoolman
Copy link
Member

Hi @innopbo,

Thanks for your clear explanation of the issue. I can see how this can be beneficial for you and probably others.

Both options proposed by you seem like good solutions. Though being able to add translation sets to custom URLs would be the best in my opinion. That way any custom URL (also the ones not tied to Strapi's data) can be translated which is just a nice feature in general.

@boazpoolman boazpoolman added the enhancement New feature or request label Aug 29, 2023
@boazpoolman boazpoolman changed the title Allow URL Bundles for single types with no field to handle translation Allow URL translation sets for custom URLs Aug 29, 2023
@innopbo
Copy link
Author

innopbo commented Sep 19, 2023

Thanks for taking a look at this. I agree the translation sets for custom URLs allows the most freedom for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants