Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluralization of Role Titles #139

Open
jeremy-putt opened this issue Nov 14, 2019 · 2 comments
Open

Pluralization of Role Titles #139

jeremy-putt opened this issue Nov 14, 2019 · 2 comments

Comments

@jeremy-putt
Copy link

I've been using this library to pluralize role titles (nurse => nurses) and it works well.

I've just hit a snag with Head of Engineering => Head of Engineerings. Where I believe the correct pluralization should be "Heads of Engineering".

Do we think this is the correct fit for this library?

@blakeembrey
Copy link
Collaborator

@jeremy-putt I'd welcome it if we can spec how this would work generally. The major problem is that this module is largely scoped to a single word and not multiple. It's probably better for a wrapper module that does this sort of thing, I've had various phrase pluralization issues in the past and I wouldn't be able to maintain it effectively here.

@jeremy-putt
Copy link
Author

That pretty much lines up with what I was thinking.

It'd be easy to add a regex like /head\sof\s(something) but I'm fairly certain there are edge cases I haven't thought of and it would probably get out of hand very quickly :)

I'll keep thinking on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants