Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Counterfact from Code #729

Open
dethell opened this issue Jan 18, 2024 · 1 comment
Open

Start Counterfact from Code #729

dethell opened this issue Jan 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dethell
Copy link
Collaborator

dethell commented Jan 18, 2024

The use case here is a Playwright test run (or some other E2E test setup) that needs to spin up Counterfact in order to run some tests.

Currently we handle this by having an npm script as the Playwright server script that starts both CF and the app engine (webpack dev server in our case). This is brittle and sometimes one or the other process doesn't start correctly. While that's likely something we could fix within the npm script setup, I see a case for being able to spin up Counterfact from within a test suite.

@pmcelhaney pmcelhaney added the enhancement New feature or request label Jan 18, 2024
@pmcelhaney
Copy link
Owner

pmcelhaney commented Jan 18, 2024

Absolutely. And expose the context objects so the tests can put the server into the state needed for testing.

Edit: I just saw #730. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants