Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

update eslint-plugin-import (no-cycle) #45

Closed
TkDodo opened this issue Dec 12, 2019 · 2 comments
Closed

update eslint-plugin-import (no-cycle) #45

TkDodo opened this issue Dec 12, 2019 · 2 comments
Labels
config This issue is about a config

Comments

@TkDodo
Copy link
Contributor

TkDodo commented Dec 12, 2019 •
edited by frycz

PR #61

As no-cycle was finally fixed to ignore flow type definitions.

We can then finally make no-cycle an error instead of a warning

https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md#2190---2019-12-08
@TkDodo
Copy link
Contributor Author

TkDodo commented Dec 12, 2019

@danielbartsch FYI

@frycz frycz mentioned this issue Feb 17, 2020
Closed
@TkDodo TkDodo added the config This issue is about a config label Mar 6, 2020
@TkDodo
Copy link
Contributor Author

TkDodo commented Nov 30, 2020

we are now on typescript, and this rule does nothing for typescript. Also, with the new feature-based folder structure, no re-exports + co-location, cyclic imports should happen less often. closing.

@TkDodo TkDodo closed this as completed Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
config This issue is about a config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/45s update eslint plugin import pmedianetwork/eslint-config
1 participant
@TkDodo