Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update type-fest version #484

Merged
merged 8 commits into from
Aug 23, 2021
Merged

chore: update type-fest version #484

merged 8 commits into from
Aug 23, 2021

Conversation

soilSpoon
Copy link
Contributor

npm 7 throws an error when installing packages if the versions of peerDependencies are not compatible.

Since type-fest is a utility package, you will likely use many versions, so you should include as many versions as possible to avoid breaking DX.

Now, this package uses only Except, SetRequired, and LiteralUnion in type-fest, so it is expected to work normally in 0.17.0 or later.

Reference

https://github.blog/2021-02-02-npm-7-is-now-generally-available/#peer-dependencies
https://github.com/sindresorhus/type-fest/releases/tag/v0.6.0
https://github.com/sindresorhus/type-fest/releases/tag/v0.8.0
https://github.com/sindresorhus/type-fest/releases/tag/v0.17.0

npm 7 throws an error when installing packages if the versions of peerDependencies are not compatible.

Since type-fest is a utility package, you will likely use many versions, so you should include as many versions as possible to avoid breaking DX.

Now, this package uses only Except, SetRequired, and LiteralUnion in type-fest, so it is expected to work normally in 0.17.0 or later.

### Reference
https://github.blog/2021-02-02-npm-7-is-now-generally-available/#peer-dependencies
https://github.com/sindresorhus/type-fest/releases/tag/v0.6.0
https://github.com/sindresorhus/type-fest/releases/tag/v0.8.0
https://github.com/sindresorhus/type-fest/releases/tag/v0.17.0
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
soilSpoon and others added 4 commits August 23, 2021 18:36
Co-authored-by: Michael Mok <pmmmwh@gmail.com>
Co-authored-by: Michael Mok <pmmmwh@gmail.com>
@pmmmwh pmmmwh self-requested a review August 23, 2021 09:48
@pmmmwh
Copy link
Owner

pmmmwh commented Aug 23, 2021

Thanks for your PR, I'll merge once all tests pass.

@pmmmwh pmmmwh merged commit 319e650 into pmmmwh:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants