Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump type-fest in peerDependencies #507

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Bump type-fest in peerDependencies #507

merged 1 commit into from
Sep 14, 2021

Conversation

soilSpoon
Copy link
Contributor

@soilSpoon soilSpoon commented Sep 14, 2021

https://github.com/sindresorhus/type-fest/releases/tag/v2.0.0

type-fest is 2.0 and there is no problem with compatibility, so bump

@pmmmwh
Copy link
Owner

pmmmwh commented Sep 14, 2021

No, type-fest v2 does not support Node.js v10 but we support that. I'm not too sure what the proper solution should be, technically it works but it will crash on install due to engine being incompatible.

@soilSpoon
Copy link
Contributor Author

No, type-fest v2 does not support Node.js v10 but we support that. I'm not too sure what the proper solution should be, technically it works but it will crash on install due to engine being incompatible.

Since you specify it as a range, can't it be 2.x and also 1.x?
I think it's the user's choice.

@pmmmwh
Copy link
Owner

pmmmwh commented Sep 14, 2021

OK, after sitting on this a bit I think it's fair to allow type-fest v2, but after merging this I'll also add a note in the README warning that v2 only supports node.js 12+.

@pmmmwh pmmmwh merged commit 2193a34 into pmmmwh:main Sep 14, 2021
@soilSpoon soilSpoon deleted the bump branch September 14, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants