Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set return type to null as a fn w/ return type 'void' is not a valid JSX element #1261

Merged
merged 2 commits into from
Feb 11, 2023
Merged

fix: set return type to null as a fn w/ return type 'void' is not a valid JSX element #1261

merged 2 commits into from
Feb 11, 2023

Conversation

rajput-hemant
Copy link
Contributor

Why

What

Checklist

  • Documentation updated
  • Storybook entry added
  • Ready to be merged

…alid JSX element

Signed-off-by: rajput-hemant <hemant.rajput_cs20@gla.ac.in>
@vercel
Copy link

vercel bot commented Jan 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
drei ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 11, 2023 at 5:19AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c914c1:

Sandbox Source
modern-platform-l5jfku Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@drcmda
Copy link
Member

drcmda commented Feb 9, 2023

it's strange because undefined is an allowed return type. where does this cause you problems?

@rajput-hemant
Copy link
Contributor Author

@drcmda

@drcmda
Copy link
Member

drcmda commented Feb 10, 2023

that issue, TS is so weird sometimes. could you quickly remove the semicolon? then let's merge.

Signed-off-by: rajput-hemant <rajput.hemant2001@gmail.com>
@rajput-hemant
Copy link
Contributor Author

@drcmda done 😇

@drcmda drcmda merged commit c765706 into pmndrs:master Feb 11, 2023
@github-actions
Copy link

🎉 This PR is included in version 9.56.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants