-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MeshRefractionMaterial): minimize shader bandwidth #1303
fix(MeshRefractionMaterial): minimize shader bandwidth #1303
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1fbe76a:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you again for this quick PR! I left a few suggestions. I had started a branch for this but I'm still getting familiar with react so I never could have done it this quickly, and with a test to boot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from 16 to 6/7 varying slots and way fewer inverses!
#endif | ||
|
||
#ifdef USE_INSTANCING | ||
vModelMatrixInverse = inverse(modelMatrix * vInstanceMatrix); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some additional savings you could pass in inverse(modelMatrix)
as a uniform too 😄
🎉 This PR is included in version 9.56.26 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #1297 by removing unneeded varyings and inlining expressions where applicable.