Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SpriteAnimator): simplified aspect ratio calculation #1467

Merged
merged 1 commit into from
May 24, 2023

Conversation

netgfx
Copy link
Contributor

@netgfx netgfx commented May 24, 2023

fix(SpriteAnimator): simplified aspect ratio calculation and fixed bu…

Why

Improved documentation
Simplified aspect ratio calculation

What

  • Added missing properties from ReadMe
  • Simplified the aspect-ratio calculation for the sprites and fixed a bug when re-rendering the Sprite while having zoomed-in/out with orbitcontrols

Checklist

  • [x ] Documentation updated (example)
  • Storybook entry added (example)
  • [x ] Ready to be merged

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 8:51pm

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d55d0d:

Sandbox Source
funny-sun-h7ucks Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@drcmda drcmda merged commit 02c140e into pmndrs:master May 24, 2023
5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 9.69.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants