Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async components? #18

Open
cah4a opened this issue Jun 22, 2023 · 2 comments · May be fixed by #19
Open

Async components? #18

cah4a opened this issue Jun 22, 2023 · 2 comments · May be fixed by #19
Labels
enhancement New feature or request

Comments

@cah4a
Copy link

cah4a commented Jun 22, 2023

It would be awesome if the package supported RSC.

For now, it's throwing an error:

Objects are not valid as a React child (found: [object Promise]). 
If you meant to render a collection of children, use an array instead.
@CodyJasonBennett CodyJasonBennett added the enhancement New feature or request label Jun 22, 2023
@CodyJasonBennett
Copy link
Member

This needs facebook/react#25634 which requires React 18.3.0. We can bundle it if we're sure it won't harm previous versions to make package managers happy.

@cah4a
Copy link
Author

cah4a commented Jun 23, 2023

Tried with react-reconciler@0.30.0-canary-c8deb5db6-20230622.

It's started working with some fixes, but async components not working. Act hangs somewhere deep in the reconciler.

@CodyJasonBennett CodyJasonBennett linked a pull request Mar 28, 2024 that will close this issue
feat!: React 19 #19
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: React 19 pmndrs/react-nil
2 participants
@cah4a @CodyJasonBennett