Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OutputPass #344

Open
s3ththompson opened this issue Jan 23, 2024 · 1 comment
Open

OutputPass #344

s3ththompson opened this issue Jan 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@s3ththompson
Copy link

three-stdlib should include the OutputPass from examples/jsm/postprocessing/OutputPass.js as a postprocessing pass.

This is the new, recommended way to apply color space / tonemapping adjustments as a postprocessing pass.

Additionally, the Effects component in Drei should be updated to use OutputPass, per pmndrs/drei#1707.
@s3ththompson s3ththompson added the enhancement New feature or request label Jan 23, 2024
@CodyJasonBennett
Copy link
Member

See the discussion there. We can add an OutputPass, but switching to it in Drei is a breaking change as well as use of premultiplied alpha here. We'd have to coordinate the two, but I'd recommend pmndrs/postprocessing for any production project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s3ththompson @CodyJasonBennett