Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot scroll #42

Open
pbmorton opened this issue Mar 29, 2017 · 13 comments
Open

Cannot scroll #42

pbmorton opened this issue Mar 29, 2017 · 13 comments

Comments

@pbmorton
Copy link

If the alert text cannot fit on the screen the text cannot be scrolled - UIAlertController in contrast supports scrolling by default. What's worse is that the PMAlertController places the "cancel" action off the screen so a user cannot then cancel the alert. The App is effectively blocked from user interaction.

Being able to handle an alert that wont fit completely on screen is important. With devices with different configurations (e.g. screen sizes, portrait, landscape) and dynamic type sizes (i.e. through the settings App a user can increase the text size) its easy to imagine some alerts not fitting a screen.

Otherwise a great library thanks!

@pmusolino
Copy link
Owner

Hi @pbmorton, great observation. I marked this issue like enhancement, i can implement this feature in a future release.

Thanks,
Paolo

@pbmorton
Copy link
Author

Thanks Paolo. Can you estimate when this feature may be supported?

@pmusolino
Copy link
Owner

Asap, I'll try this week ;)

@javalnanda
Copy link

@codeido Have applied the quick workaround for the scroll issue. Do check if it looks good to you #45

@pmusolino
Copy link
Owner

@javalnanda thanks for this PR, but i think that your workaround is not a final solution. First of all, if you substitute the label description with a textview you break the back compatibility. This feature need to be an enhancement. 2nd: this solution include only some cases, because if you have a lot of buttons, you have a small textview for the description (probably with height == 0).

@javalnanda
Copy link

@codeido Makes sense, the back compatibility will be a major issue. Are you thinking of embedding entire alert view inside a scroll view?

@pmusolino
Copy link
Owner

Yes, i think that is the best solution.

@javalnanda
Copy link

ok, 👍 Let me know if you are already working on it. Else, I could spend some time on it the coming week.

@javalnanda
Copy link

@codeido Scrolling entire alert view looks really bad. Just tried out. The Default AlertController also scrolls only the text part. I think we will need to scroll only the content part except Alert Action Stack View

@javalnanda
Copy link

@codeido Sent one more PR, see if it is helpful. Also, I think it will be good to have a limit to the number of action buttons to max 5 or 6 maybe. Just a suggestion :)

@edwardmp
Copy link

Hi @codeido

thanks for this nice alert controller! Wondering if you ever got around the merging in a fix for this?

@thatmarcel
Copy link

@pmusolino When will the feature be implemented?

@sm0nster
Copy link

sm0nster commented Apr 9, 2020

It's still unscrollable, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants